Use field to replace a few more explicit ThreadStatic fields#120243
Merged
stephentoub merged 1 commit intodotnet:mainfrom Sep 30, 2025
Merged
Use field to replace a few more explicit ThreadStatic fields#120243stephentoub merged 1 commit intodotnet:mainfrom
field to replace a few more explicit ThreadStatic fields#120243stephentoub merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes ThreadStatic field patterns by replacing explicit ThreadStatic field declarations with the newer field keyword syntax in auto-properties. This simplifies the code by eliminating the need for separate backing fields and getter/setter logic.
Key changes:
- Replaces
[ThreadStatic] private static Type? t_field;patterns with[field: ThreadStatic]on auto-properties - Consolidates multi-line property implementations into single-line expressions using
field ??= new() - Removes redundant backing fields and associated boilerplate code
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| System/Transactions/Transaction.cs | Converts ContextData ThreadStatic field to use field keyword in TLSCurrentData property |
| CoseTestHelpers.cs | Simplifies TestKeyRing ThreadStatic property using field keyword |
| System/Diagnostics/Debug.cs | Updates IndentLevel ThreadStatic property to use field keyword |
| RandomNumberGenerator.cs | Converts Current property ThreadStatic backing field to field keyword |
| ImportType.cs | Simplifies CastSingleValueCache ThreadStatic property using field keyword |
| ContractNameServices.cs | Updates TypeIdentityCache ThreadStatic property to use field keyword |
| LazyAsyncResult.cs | Converts CurrentThreadContext ThreadStatic property to use field keyword |
jamesdayo080-cell
approved these changes
Sep 30, 2025
jkotas
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.