JIT: Update overview document and rename a few methods#119762
Merged
jakobbotsch merged 2 commits intodotnet:mainfrom Sep 30, 2025
Merged
JIT: Update overview document and rename a few methods#119762jakobbotsch merged 2 commits intodotnet:mainfrom
jakobbotsch merged 2 commits intodotnet:mainfrom
Conversation
- Update list of phases in the overview to include some more phases - Rename one of the `compCompile` overloads to `compCompileAfterInit`. Keep `compCompile` as the method that runs the phases. - Rename local morph to actually be called local morph - Leave a note in the ryujit tutorial that the phase information and details are out of date, and point into the overview instead
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation and renames methods to improve clarity and consistency in the JIT codebase. The primary focus is on better documenting JIT phases and making method names more descriptive.
Key changes:
- Updates the RyuJIT overview document with more comprehensive phase information and corrected details
- Renames
fgMarkAddressExposedLocalstofgLocalMorphto better reflect its broader functionality - Renames one
compCompileoverload tocompCompileAfterInitto distinguish initialization from phase execution
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/lclmorph.cpp | Renames function and updates comment to reflect broader local morphing functionality |
| src/coreclr/jit/ee_il_dll.cpp | Updates comment reference and simplifies memcpy operation |
| src/coreclr/jit/compphases.h | Renames phase constant to match the new function name |
| src/coreclr/jit/compiler.h | Updates function declaration and fixes typo in comment |
| src/coreclr/jit/compiler.cpp | Updates function calls and renames method implementation |
| docs/design/coreclr/jit/ryujit-tutorial.md | Adds deprecation notice and reference to updated overview |
| docs/design/coreclr/jit/ryujit-overview.md | Comprehensive updates to phase descriptions, IR details, and technical accuracy |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
commented
Sep 16, 2025
Member
Author
|
PTAL @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Sep 19, 2025
Member
AndyAyersMS
left a comment
There was a problem hiding this comment.
Left a comment for one bit I found confusing.
Member
Author
|
/ba-g Deadletter on trivial change |
Member
|
Thanks for updating the overview doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compCompileoverloads tocompCompileAfterInit. KeepcompCompileas the method that runs the phases.