[interp] Null-check calli function pointers + interp diagnostics #119663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds null-checking for function pointers in the CALLI instruction handler within the CoreCLR interpreter. The change ensures that function pointers are validated before use to prevent potential null dereference issues.
Key changes:
- Add null-check validation for CALLI function pointers before invocation
- Refactor to use a local variable for the function pointer to avoid redundant LOCAL_VAR calls
992b4b9 to
7115812
Compare
This was referenced Sep 16, 2025
Open
7115812 to
71275a8
Compare
Member
Author
|
@janvorli I think I addressed your feedback, lmk if you want more changes |
Maybe fix linux build Fail fast when INTOP_GETSTUBCONTEXT doesn't have a stub context to get If InterpDump is active, print to the console when BADCODE() aborts compilation Address PR feedback Address feedback Make InterpreterStub handle being called on threads without a Thread object
71275a8 to
7b30f7c
Compare
janvorli
approved these changes
Sep 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check failure in baseservices\invalid_operations\InvalidOperations revealed that we need to do this, I think. This doesn't fix the test though, something else is wrong with it.
The reason the calli ptr is null is that the stubcontext value is null, so I also updated the interpreter to fail-fast when this happens - it should never be null.
Also adds some interp diagnostics so that if BADCODE() aborts compilation on a method we're dumping, we print the failure reason to the console.