Redirect taskkill.exe in HelixPre/PostCommands output to nul#119544
Merged
jkotas merged 1 commit intodotnet:mainfrom Sep 10, 2025
Merged
Redirect taskkill.exe in HelixPre/PostCommands output to nul#119544jkotas merged 1 commit intodotnet:mainfrom
jkotas merged 1 commit intodotnet:mainfrom
Conversation
This prints "ERROR: The process "corerun.exe" not found" under normal circumstances that makes it look like an actual test failure. Fixes dotnet#119525
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR suppresses error output from taskkill.exe commands in the Helix test infrastructure to prevent misleading error messages. The change addresses the issue where normal "process not found" messages from taskkill were appearing as test failures in logs.
- Redirects stderr to null for taskkill commands that clean up corerun.exe processes
- Applies the same fix to both HelixPreCommand and HelixPostCommand sections
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
mangod9
approved these changes
Sep 10, 2025
akoeplinger
approved these changes
Sep 10, 2025
jkoritzinsky
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prints "ERROR: The process "corerun.exe" not found" under normal circumstances that makes it look like an actual test failure.
Fixes #119525