Use VN to set initial range in TryGetRangeFromAssertions#119474
Merged
EgorBo merged 3 commits intodotnet:mainfrom Sep 9, 2025
Merged
Use VN to set initial range in TryGetRangeFromAssertions#119474EgorBo merged 3 commits intodotnet:mainfrom
EgorBo merged 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves range analysis in the JIT by using value numbering (VN) information to set initial ranges before processing assertions. The change addresses issue #119466 by adding VN-based range initialization to the TryGetRangeFromAssertions method.
Key changes:
- Added VN-based initial range computation for constants, casts, and array lengths
- Fixed incorrect range initialization from
keDependent/keUndeftokeUnknown - Removed unnecessary condition check in relational operator folding
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/jit/rangecheck.cpp | Enhanced TryGetRangeFromAssertions to use VN information for setting initial ranges before assertion processing |
| src/coreclr/jit/assertionprop.cpp | Fixed range initialization to use keUnknown instead of incorrect limit types and removed unnecessary condition |
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib a small change to set initial Range based on VN in |
jakobbotsch
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119466
Diffs