Skip to content

Disable MSBuild wrapping more thoroughly#119331

Merged
akoeplinger merged 1 commit intodotnet:mainfrom
SingleAccretion:More-Clp-Args
Sep 4, 2025
Merged

Disable MSBuild wrapping more thoroughly#119331
akoeplinger merged 1 commit intodotnet:mainfrom
SingleAccretion:More-Clp-Args

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Sep 3, 2025 •
edited
Loading

It turns out that #119282 is not enough to disable the wrapping when invoking the top-level ./build.[cmd|sh] script (it works as expected when dotnet building projects manually).

Why?

Because the top-level build uses a project from the Nuget cache, outside of the runtime source tree.

Example command line 
"C:\Users\Accretion\source\dotnet\runtime\.dotnet\dotnet.exe" msbuild /m /nologo /clp:Summary /v:minimal /nr:True /p:ContinuousIntegrationBuild=False /p:TreatWarningsAsErrors=false "C:\Users\Accretion\.nuget\packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.25420.121\tools\Build.proj" "/p:Configuration=Debug" "/p:RepoRoot=C:\Users\Accretion\source\dotnet\runtime\\" "/p:Restore=True" "/p:DeployDeps=False" "/p:Build=True" "/p:Rebuild=False" "/p:Deploy=False" "/p:Test=False" "/p:Pack=False" "/p:DotNetBuild=False" "/p:DotNetBuildFromVMR=False" "/p:IntegrationTest=False" "/p:PerformanceTest=False" "/p:Sign=False" "/p:Publish=False" "/p:RestoreStaticGraphEnableBinaryLogger=False" "/p:TargetArchitecture=wasm" "/p:TargetOS=browser" "/p:Ninja=false" "/p:subset=libs.native" "/tl:false"

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 3, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2025
@SingleAccretion SingleAccretion added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 3, 2025
@SingleAccretion SingleAccretion marked this pull request as ready for review September 3, 2025 20:07
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Sep 3, 2025

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

akoeplinger commented Sep 4, 2025

/ba-g unrelated download failure

@akoeplinger akoeplinger merged commit 99ef82f into dotnet:main Sep 4, 2025
150 of 152 checks passed
@SingleAccretion SingleAccretion deleted the More-Clp-Args branch September 4, 2025 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion @akoeplinger @jkoritzinsky @ViktorHofer