Adding GetReJITInformation cDAC API #119111

rcj1 · 2025-08-26T19:09:27Z

Adding SHash implementation (needed to get dynamic IL)
Adding GetReJITInformation cDAC API

dotnet-policy-service · 2025-08-26T19:10:27Z

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

docs/design/datacontracts/CodeVersions.md

docs/design/datacontracts/RuntimeTypeSystem.md

src/coreclr/vm/datadescriptor/datadescriptor.inc

...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs

docs/design/datacontracts/Loader.md

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/SHash.cs

src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs

...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs

Restructuring SHash

…er.Contracts/Contracts/RuntimeTypeSystem_1.cs Co-authored-by: Max Charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot

Pull Request Overview

This PR adds the GetReJITInformation cDAC API by implementing support for SHash data structures and extending the code versioning infrastructure. The changes enable accessing dynamic IL information needed for ReJIT operations.

Key changes:

Implements SHash contract and supporting infrastructure for hash table operations
Adds GetReJITInformation API with proper cDAC implementation
Extends data contracts to support dynamic IL blob tables and async method data

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`SOSDacImpl.cs`	Implements the complete GetReJITInformation API replacing the stub implementation
`ISOSDacInterface.cs`	Defines DacpReJitData2 structure and updates method signature
`SHash_1.cs`	Implements SHash contract for hash table operations
`CodeVersions_1.cs`	Adds GetIL method to retrieve IL addresses from code versions
`RuntimeTypeSystem_1.cs`	Adds MayHaveILHeader method and async method detection
`Loader_1.cs`	Implements GetILHeader method with dynamic IL blob support
Various data contracts	Adds new data structures for DynamicILBlobEntry, AsyncMethodData, and Module extensions
Documentation	Adds comprehensive documentation for SHash, CodeVersions, and RuntimeTypeSystem contracts

Comments suppressed due to low confidence (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/SHash_1.cs:1

The IsDeleted check is being called with the wrong parameter type. It should check if the current entry is deleted, not the key. Change to if (!shashTable.Traits.IsDeleted(current) && shashTable.Traits.Equals(key, shashTable.Traits.GetKey(current)))

// Licensed to the .NET Foundation under one or more agreements.

docs/design/datacontracts/SHash.md

docs/design/datacontracts/Loader.md

src/coreclr/vm/datadescriptor/datadescriptor.inc

...ve/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ILCodeVersionNode.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

docs/design/datacontracts/SHash.md

src/coreclr/vm/datadescriptor/datadescriptor.inc

src/coreclr/vm/datadescriptor/contracts.jsonc

...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ISHash.cs

src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs

src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs

src/coreclr/vm/datadescriptor/datadescriptor.inc

...ve/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ILCodeVersionNode.cs

docs/design/datacontracts/CodeVersions.md

jkotas · 2025-09-12T07:43:16Z

Should the existing C/C++ DAC skip MayHaveILHeader and MethodDesc roundtrip too so that it produces the same results as cDAC?

rcj1 · 2025-09-12T17:05:20Z

Should the existing C/C++ DAC skip MayHaveILHeader and MethodDesc roundtrip too so that it produces the same results as cDAC?

I can make that change

src/coreclr/vm/codeversion.cpp

jkotas · 2025-09-13T00:02:10Z

LGTM otherwise

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

src/coreclr/vm/codeversion.cpp

docs/design/datacontracts/Loader.md

src/coreclr/vm/datadescriptor/datadescriptor.inc

...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs

src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs

src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs

…into GetReJITInformation2

max-charlamb

lgtm. thanks

rcj1 added 5 commits August 21, 2025 15:29

e

80500ef

merge

9aef193

Adding GetRejitInformation cDAC API

8c61fb9

removing stuff

a27fe20

data descriptors and other things

97e0bbd

rcj1 requested review from Copilot, max-charlamb and noahfalk and removed request for Copilot August 26, 2025 19:09

github-actions bot added the area-Diagnostics-coreclr label Aug 26, 2025

dotnet-policy-service bot assigned rcj1 Aug 26, 2025

max-charlamb reviewed Aug 27, 2025

View reviewed changes

rcj1 marked this pull request as draft August 29, 2025 16:43

rcj1 and others added 6 commits September 2, 2025 16:22

Restructuring SHash

a57ebfd

Merge pull request #1 from rcj1/GetRejitInformation2

9d2ff6a

Restructuring SHash

Update src/native/managed/cdac/Microsoft.Diagnostics.DataContractRead…

b604312

…er.Contracts/Contracts/RuntimeTypeSystem_1.cs Co-authored-by: Max Charlamb <44248479+max-charlamb@users.noreply.github.com>

code review

8385c81

Merge branch 'main' into GetReJITInformation2

6df6dab

docs etc

ed56e0c

rcj1 marked this pull request as ready for review September 4, 2025 22:42

rcj1 requested review from Copilot and davidwrighton September 4, 2025 22:42

Copilot AI reviewed Sep 4, 2025

View reviewed changes

rcj1 and others added 2 commits September 4, 2025 16:07

Apply suggestions from code review

44515ca

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix entry retrieval condition in SHash_1.cs

dc6f926

max-charlamb reviewed Sep 9, 2025

View reviewed changes

docs/design/datacontracts/SHash.md Outdated Show resolved Hide resolved

src/coreclr/vm/datadescriptor/datadescriptor.inc Show resolved Hide resolved

max-charlamb reviewed Sep 9, 2025

View reviewed changes

code review

ab5eab3

noahfalk reviewed Sep 10, 2025

View reviewed changes

docs/design/datacontracts/CodeVersions.md Show resolved Hide resolved

docs/design/datacontracts/CodeVersions.md Outdated Show resolved Hide resolved

rcj1 added 3 commits September 11, 2025 10:12

removing method desc lookup and other codereview items

2bb3887

Merge branch 'main' into GetReJITInformation2

42ed484

comments

c888ea4

replacing method desc to IL lookup with module+method def to IL lookup

308d7e8

jkotas reviewed Sep 12, 2025

View reviewed changes

src/coreclr/vm/codeversion.cpp Outdated Show resolved Hide resolved

jkotas reviewed Sep 12, 2025

View reviewed changes

src/coreclr/vm/codeversion.cpp Outdated Show resolved Hide resolved

fix

f156997

This was referenced Sep 12, 2025

Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_Create_Invalid #94498

Open

System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_GetCounters Failed #110454

Closed

jkotas reviewed Sep 13, 2025

View reviewed changes

src/coreclr/vm/codeversion.cpp Show resolved Hide resolved

Update src/coreclr/vm/codeversion.cpp

503a8a6

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas reviewed Sep 13, 2025

View reviewed changes

src/coreclr/vm/codeversion.cpp Outdated Show resolved Hide resolved

jkotas and others added 2 commits September 12, 2025 20:05

Update src/coreclr/vm/codeversion.cpp

0266a0d

Fix typo in IsMiIL function call

4c1fe00

max-charlamb reviewed Sep 15, 2025

View reviewed changes

rcj1 added 2 commits September 15, 2025 14:15

codereview

7004857

Merge branch 'GetReJITInformation2' of https://github.com/rcj1/runtime …

80dca0e

…into GetReJITInformation2

max-charlamb approved these changes Sep 15, 2025

View reviewed changes

rcj1 merged commit 8e80e90 into dotnet:main Sep 16, 2025
100 of 102 checks passed

rcj1 deleted the GetReJITInformation2 branch September 16, 2025 01:29

max-charlamb mentioned this pull request Sep 26, 2025

include memory required to do MethodDefLookup in minidumps #120119

Merged

steveisok mentioned this pull request Sep 26, 2025

[release/10.0] include memory required to do MethodDefLookup in minidumps #120148

Merged

4 tasks

github-actions bot locked and limited conversation to collaborators Oct 16, 2025

Adding GetReJITInformation cDAC API #119111

Adding GetReJITInformation cDAC API #119111

Uh oh!

Conversation

rcj1 commented Aug 26, 2025

Uh oh!

dotnet-policy-service bot commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Sep 12, 2025

Uh oh!

rcj1 commented Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Sep 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants