Fixup some Vector<T> function lookups to use the right name/type #119068
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Vector function lookups to use the correct names and types in the JIT compiler. The changes address issues where comparison operations and the SquareRoot method were not being properly recognized by the intrinsic lookup system, which could lead to missed optimizations.
Key changes:
- Added mapping from "SquareRoot" to "Sqrt" for method name lookup
- Added
HW_Flag_BaseTypeFromFirstArgflag to comparison intrinsics (Equals, GreaterThan, etc.) to ensure proper type resolution - Added regression test to verify Vector.LessThan functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/coreclr/jit/importercalls.cpp |
Added method name mapping for SquareRoot to Sqrt |
src/coreclr/jit/hwintrinsiclistxarch.h |
Added BaseTypeFromFirstArg flag to comparison intrinsics for x86/x64 |
src/coreclr/jit/hwintrinsiclistarm64.h |
Added BaseTypeFromFirstArg flag to comparison intrinsics for ARM64 |
src/tests/JIT/Regression/JitBlue/Runtime_119008/Runtime_119008.csproj |
Test project configuration for regression test |
src/tests/JIT/Regression/JitBlue/Runtime_119008/Runtime_119008.cs |
Regression test verifying Vector.LessThan behavior |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
src/tests/JIT/Regression/JitBlue/Runtime_119008/Runtime_119008.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/10.0-rc1 |
|
Started backporting to release/10.0-rc1: https://github.com/dotnet/runtime/actions/runs/17213927490 |
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17222455059 |
This resolves #119066 and resolves #118848
This will need backport to .NET 10