Support IAT_PVALUE string literals in the interpreter#119011
Merged
kg merged 3 commits intodotnet:mainfrom Aug 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for IAT_PVALUE string literals in the CoreCLR interpreter, enabling proper handling of string references that require indirection. The key enhancement is implementing the INTOP_LDIND_O instruction and updating the string literal compilation logic to handle both direct (IAT_VALUE) and indirect (IAT_PVALUE) string access patterns.
Key changes:
- Implements INTOP_LDIND_O instruction for object indirection in the interpreter execution engine
- Updates string literal compilation to handle IAT_PVALUE access type with proper indirection logic
- Reorganizes instruction generation order to support the new indirection pattern
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/vm/interpexec.cpp | Adds INTOP_LDIND_O case to interpreter execution switch statement |
| src/coreclr/interpreter/compiler.cpp | Updates string literal compilation to handle IAT_PVALUE with indirection and reorganizes instruction data assignment |
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
BrzVlad
reviewed
Aug 25, 2025
69 tasks
davidwrighton
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for IAT_PVALUE string literals and removes INTOP_LDIND_O. This fixes JIT\regression\jitblue\Runtime_100437