Skip to content

[release/10.0] Move FlushProcessWriteBuffers to minipal #118984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 27 commits into from
Closed

[release/10.0] Move FlushProcessWriteBuffers to minipal #118984

github-actions wants to merge 27 commits into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 22, 2025 •
edited by simonrozsival
Loading

Backport of #118161 to release/10.0

/cc @simonrozsival @radekdoulik

Customer Impact

  • Customer reported
  • Found internally

Without this change, CoreCLR on Android API 21-28 crashes during startup (see #115480). The PR was not ready before the RC1 snap.

Regression

  • Yes
  • No

CoreCLR on Android is a new feature in .NET 10.

Testing

Unit tests.

Risk

Low. The changes in this PR unrelated to Android are mostly refactoring.

radekdoulik and others added 27 commits August 22, 2025 10:21
@radekdoulik
Move FlushProcessWriteBuffers to minipal
f7fe002 
Implements #117977

Also move the initialization of it and get of page size
@radekdoulik
Fix build
33a4e83
@radekdoulik
Fix linux build
b2c5dba
@radekdoulik @am11
Update definitions
70c2e2a 
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@radekdoulik
Feedback
af799e7 
Do not care about cleanup
@radekdoulik
Feedback
a13c841 
Do not move page size to minipal
@radekdoulik
Feedback
23b9593 
Rename the files
@radekdoulik
Feedback
6cc8ced 
Changes which were missed in earlier commits
@radekdoulik
Feedback
2fb42a3 
Remove PalFlushProcessWriteBuffers wrapper
@radekdoulik
Feedback
59e6958 
Remove parts around g_helperPage on mac
@radekdoulik
Feedback
5edc898 
Rename to memory_barrier_process_wide
@radekdoulik @am11
Fix mac build
4a42355 
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@radekdoulik
Fix build
0361746
@radekdoulik
Fix windows build
9396dc8
@radekdoulik @am11
More specific include
de63052 
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@radekdoulik @am11
Fix windows build
7066c11 
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@radekdoulik
Feedback
f1c4f4f 
Remove windows wrapper too
@radekdoulik @am11
Use more generic include again
2949aac 
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@radekdoulik @jkotas
Apply suggestions from code review
77e1394 
Refactor ifdefs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Fix build
cf613bc
@radekdoulik
Complete the suggestion from feedback
f5a57b4
@radekdoulik
Feedback
5491bd8 
Call `minipal_initialize_memory_barrier_process_wide` from unix
`GCToOSInterface::Initialize`. Let it return true if it was previously
successfully initialized.
@radekdoulik
Fix windows build
c8f8a6e
@radekdoulik @jkotas
Apply suggestions from code review
491b28b 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Feedback
42e19d3 
Refactor minipal_memory_barrier_process_wide
@radekdoulik
Fix build
5976915
@jkotas
Apply suggestions from code review
5cfda4f
@jkotas
Copy link
Member

jkotas commented Aug 22, 2025 •
edited
Loading

If we need the fix in .NET 10 for Android, we should do a small targeted fix for .NET 10 that just adds the few lines under Android ifdef. Backporting of this refactoring has unnecessary risk.

This was referenced Aug 22, 2025
Open
Open
@simonrozsival
Copy link
Member

simonrozsival commented Aug 22, 2025

@jkotas ok, makes sense. I'm closing this PR now and I'll open the targeted change next week.

@simonrozsival simonrozsival deleted the backport/pr-118161-to-release/10.0 branch August 22, 2025 20:20
@simonrozsival simonrozsival mentioned this pull request Aug 25, 2025
Merged
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

No one assigned

Labels

area-PAL-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas @simonrozsival @radekdoulik