Fix file size estimation when bundling symlinks #118732

corngood · 2025-08-14T14:33:45Z

FileInfo.Length will return the size of a symlink, rather than the file itself. On a source-built dotnet SDK, a trivial test project will bundle files like:

packs/Microsoft.NETCore.App.Runtime.linux-x64/10.0.0-preview.7.25380.108/runtimes/linux-x64/lib/net10.0/Microsoft.CSharp.dll

Which is a symlink to:

../../../../../../../shared/Microsoft.NETCore.App/10.0.0-preview.7.25380.108/Microsoft.CSharp.dll

This can result in:

[...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: The "GenerateBundle" task failed unexpectedly. [/build/test/test.fsproj]
[...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: System.NotSupportedException: Unable to expand length of this stream beyond its capacity. [/build/test/test.fsproj]
[...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at System.IO.UnmanagedMemoryStream.WriteCore(ReadOnlySpan1 buffer) [/build/test/test.fsproj] [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at System.IO.Stream.CopyTo(Stream destination, Int32 bufferSize) [/build/test/test.fsproj] [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.HostModel.Bundle.Bundler.AddToBundle(Stream bundle, FileStream file, FileType type) [/build/test/test.fsproj] [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.HostModel.Bundle.Bundler.GenerateBundle(IReadOnlyList1 fileSpecs) [/build/test/test.fsproj]
[...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.Build.Tasks.GenerateBundle.ExecuteCore() [/build/test/test.fsproj]
[...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.Build.Tasks.TaskBase.Execute() [/build/test/test.fsproj]
[...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() [/build/test/test.fsproj]
[...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMo

Fixes: b79c4fb

dotnet-policy-service · 2025-08-15T14:19:06Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

src/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs

jtschuster

Could we also use this helper here

runtime/src/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs

Line 127 in 0d803c3

long appHostSourceLength = new FileInfo(appHostSourceFilePath).Length;

and here

runtime/src/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs

Line 317 in 0d803c3

var hostLength = new FileInfo(hostSource).Length;

corngood · 2025-08-18T20:17:31Z

Could we also use this helper here

I moved it to HostModelUtils. I believe everything existing in there is actually unused, but it seems like the best spot in the project. Let me know if you have a better idea.

src/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj

src/installer/managed/Microsoft.NET.HostModel/HostModelUtils.cs

src/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj

corngood · 2025-08-18T23:48:36Z

##[error].dotnet/sdk/10.0.100-rc.1.25411.109/Microsoft.Common.CurrentVersion.targets(2437,5): error MSB3106: (NETCORE_ENGINEERING_TELEMETRY=Build) Assembly strong name "/__w/1/s/.packages/microsoft.io.redist/6.1.3/lib/net462/Microsoft.IO.Redist.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(\). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(\).

I switched the reference to net472, since that's all that's available even in the oldest versions on nuget.org. Based on some other dependencies I think that's probably okay, but I'm not sure.

jkotas · 2025-08-19T13:43:51Z

@corngood To fix the build breaks, try changing Microsoft.IO.Redist version to 6.0.1

FileInfo.Length will return the size of a symlink, rather than the file itself. On a source-built dotnet SDK, a trivial test project will bundle files like: packs/Microsoft.NETCore.App.Runtime.linux-x64/10.0.0-preview.7.25380.108/runtimes/linux-x64/lib/net10.0/Microsoft.CSharp.dll Which is a symlink to: ../../../../../../../shared/Microsoft.NETCore.App/10.0.0-preview.7.25380.108/Microsoft.CSharp.dll This can result in: > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: The "GenerateBundle" task failed unexpectedly. [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: System.NotSupportedException: Unable to expand length of this stream beyond its capacity. [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at System.IO.UnmanagedMemoryStream.WriteCore(ReadOnlySpan`1 buffer) [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at System.IO.Stream.CopyTo(Stream destination, Int32 bufferSize) [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.HostModel.Bundle.Bundler.AddToBundle(Stream bundle, FileStream file, FileType type) [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.HostModel.Bundle.Bundler.GenerateBundle(IReadOnlyList`1 fileSpecs) [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.Build.Tasks.GenerateBundle.ExecuteCore() [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.NET.Build.Tasks.TaskBase.Execute() [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() [/build/test/test.fsproj] > [...]/Microsoft.NET.Publish.targets(1132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMo Fixes: b79c4fb

jtschuster

Thank you!

elinor-fung · 2025-09-05T18:34:00Z

/backport to release/10.0

github-actions · 2025-09-05T18:34:09Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17501524581

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2025

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 14, 2025

vcsjones added area-HostModel Microsoft.NET.HostModel issues and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 15, 2025

lewing reviewed Aug 15, 2025

View reviewed changes

src/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated Show resolved Hide resolved

corngood force-pushed the bundler-fix branch from d60f4ef to 31a0e16 Compare August 16, 2025 13:30

build-analysis bot mentioned this pull request Aug 16, 2025

Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488

Open

corngood force-pushed the bundler-fix branch from 31a0e16 to c3cc2a6 Compare August 18, 2025 14:40

agocke assigned jtschuster and elinor-fung Aug 18, 2025