Skip to content

[RISC-V] De-intrinsify Min/MaxMagnitude#118589

Merged
jakobbotsch merged 14 commits intodotnet:mainfrom
tomeksowi:minmax-magnitude-fallback
Oct 2, 2025
Merged

[RISC-V] De-intrinsify Min/MaxMagnitude#118589
jakobbotsch merged 14 commits intodotnet:mainfrom
tomeksowi:minmax-magnitude-fallback

Conversation

@tomeksowi
Copy link
Member

@tomeksowi tomeksowi commented Aug 11, 2025 •
edited
Loading

Fallback to the library version, the generated version returned the lesser/greater magnitude instead of the original argument with such.

Also adjust Min/Max(Number) routines to adhere to new NaN requirements in #119897

Part of #84834, cc @dotnet/samsung

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 11, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 11, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 11, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tomeksowi
Copy link
Member Author

tomeksowi commented Aug 11, 2025

@risc-vv /run

@risc-vv
Copy link

risc-vv commented Aug 11, 2025 •
edited
Loading

RISC-V pull_request-CLR-QEMU: 9101 / 9131 (99.67%) 
=======================
      passed: 9101
      failed: 2
     skipped: 591
      killed: 28
------------------------
 TOTAL tests: 9722
VIRTUAL time: 80h 42min 24s 237ms
   REAL time: 1h 19min 1s 481ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V pull_request-CLR-VF2: 9101 / 9131 (99.67%) 
=======================
      passed: 9101
      failed: 2
     skipped: 591
      killed: 28
------------------------
 TOTAL tests: 9722
VIRTUAL time: 32h 0min 35s 150ms
   REAL time: 2h 7min 10s 321ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V pull_request-FX-QEMU: 0 / 1 (0.00%) 
=======================
      passed: 0
      failed: 0
     skipped: 14
      killed: 1
------------------------
 TOTAL tests: 15
VIRTUAL time: 15s 444ms
   REAL time: 4h 30min 0s 487ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V pull_request-FX-VF2: 0 / 66 (0.00%) 
=======================
      passed: 0
      failed: 0
     skipped: 14
      killed: 66
------------------------
 TOTAL tests: 80
VIRTUAL time: 1min 14s 522ms
   REAL time: 12h 30min 7s 384ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 0d012b4d1be3ca4ebd5e3600f19920d644db105b
CI: d023c7d591ab286aa343d644f00b5daa59d8d6b0
REPO: dotnet/runtime
BRANCH: main
CONFIG: Checked
LIB_CONFIG: Release

This was referenced Aug 11, 2025
Closed
Closed
Open
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Aug 12, 2025
@tomeksowi tomeksowi marked this pull request as ready for review August 12, 2025 06:29
@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Sep 8, 2025

@tannergooding and @jakobbotsch, please review this PR.

tannergooding
tannergooding reviewed Sep 18, 2025
View reviewed changes
tannergooding
tannergooding reviewed Sep 18, 2025
View reviewed changes
@tannergooding tannergooding mentioned this pull request Sep 19, 2025
Open
tomeksowi
tomeksowi commented Sep 25, 2025
View reviewed changes
jakobbotsch
jakobbotsch reviewed Sep 29, 2025
View reviewed changes
tannergooding
tannergooding reviewed Sep 30, 2025
View reviewed changes
tannergooding
tannergooding reviewed Sep 30, 2025
View reviewed changes
@tannergooding
Copy link
Member

tannergooding commented Oct 1, 2025

Thanks! Will let @jakobbotsch give it another pass as well, but I think this looks good to merge

jakobbotsch
jakobbotsch reviewed Oct 2, 2025
View reviewed changes
@jakobbotsch jakobbotsch merged commit 2fb5cb1 into dotnet:main Oct 2, 2025
118 checks passed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 14, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

@tomeksowi tomeksowi

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tomeksowi @risc-vv @JulieLeeMSFT @tannergooding @jakobbotsch @clamp03