limit regions_range to 2x physical_mem for WKS #118516
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the garbage collector initialization in NativeAOT to use a more conservative memory reservation strategy. Instead of using the larger of 256GB or 2x physical memory, NativeAOT will now only reserve 2x physical memory for its regions range.
- Reduces memory reservation footprint for NativeAOT applications
- Better accommodates scenarios with multiple NativeAOT libraries in a single process
- Maintains existing behavior for non-NativeAOT runtimes
Comments suppressed due to low confidence (1)
|
Tagging subscribers to this area: @dotnet/gc |
MichalStrehovsky
left a comment
There was a problem hiding this comment.
The comment at #118433 (comment) makes it appear this might cause performance issues that we do not understand. I would prefer not having a native AOT specific configuration that causes perf issues we do not understand.
|
I agree with Michal that it is not desirable to have diverging GC defaults between regular CoreCLR and NativeAOT, in particular if we believe that it causes performance issues. Our test strategy for NativeAOT assumes that NativeAOT is identical to regular CoreCLR as much as possible. If we were to start diverging NativeAOT and CoreCLR behavior with GC defaults, we would need to introduce duplicated test and perf coverage for NativeAOT. |
|
We were considering whether we can make the change globally for WKS, but that needs more thought (so perhaps in 11). We can look into a better message when GC is unable to reserve space. |
|
I think it's fine to make the change for WKS but you'd want to do some perf runs. note that on large machines this can of course mean more than 256GB reserved. and if you anticipate nativeaot apps to run on large systems (like a little service running along side large server apps), you'd probably want to put a cap on that so you'd want |
|
|
|
@MichalStrehovsky Could you please clear your "changes requested" if this change looks reasonable to you? |
The change is no longer native AOT specific
|
we are doing some perf validation to ensure there aren't any regressions in GCPerfSim scenarios. |
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17307393837 |
this will work better for scenarios where multiple NativeAOT libraries are used within a process.
This will alleviate GC initialization for certain scenarios, but manual configuration might be needed. Perhaps we can improve the error message when we fail to reserve the regions_range.