Remove 2GB allocations from MemoryStream_SeekOverflow_Throws. #118400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was allocating arrays that were nearly 2GB in size in order to attempt to test an edge case around seek overflowing. These large allocations are very unable in CI and started failing for Android + CoreCLR. The test is already disabled for Linux, for iOS, for tvOS, and partially for Windows. Rather than disable it yet again, let's just not test the very large allocation sizes. At this point the test has been disabled on so many platforms for being problematic we aren't getting much value from the large allocations.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes problematic 2GB memory allocations from the MemoryStream_SeekOverflow_Throws test that were causing CI failures across multiple platforms. The test was already disabled on many platforms (Linux, iOS, tvOS, and partially Windows) due to these large allocation issues.
- Removes the
Array.MaxLengthtest data entries that were causing 2GB allocations - Removes platform-specific skip attributes and issue tracking attributes
- Changes from
ConditionalTheorytoTheorysince 64-bit process requirement is no longer needed
Member
Author
|
In fact we are adding back test coverage by removing the 2 GB allocations. We were disabling the test wholesale on many platforms, but not all of the theories were creating large allocations. Now we are back to testing the small allocations on more platforms. |
jkotas
approved these changes
Aug 5, 2025
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was allocating arrays that were nearly 2GB in size in order to attempt to test an edge case around seek overflowing. These large allocations are very unstable in CI and started failing for Android + CoreCLR.
The test is already disabled for Linux, for iOS, for tvOS, and partially for Windows. Rather than disable it for yet another platform, let's just not test the very large allocation sizes. At this point the test has been disabled on so many platforms for being problematic we aren't getting much value from the large allocations.
Fixes #92467
Fixes #100225
Fixes #100558
Fixes #118353