Add ETW nostack entries for DebugExceptionProcessing events #118194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds ETW nostack entries for DebugExceptionProcessing events to prevent ETW stackwalk failures when breakpoints are present on the stack. This follows the same pattern established in #114585 for similar debug-related events.
Key Changes
- Adds nostack entries for DebugExceptionProcessingStart and DebugExceptionProcessingEnd events
hoyosjs
approved these changes
Jul 30, 2025
Member
hoyosjs
left a comment
There was a problem hiding this comment.
A little sad to lose this, but as long as the regular exception ones still contain a stack, it's ok.
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112226. Similar to #114585, the ETW stackwalk may fail if there is a breakpoint on the stack.