[10.0-preview7] Update DBG_MAX_EXECUTABLE_ALLOC_SIZE and EXPECTED_CHUNKSIZE #117912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…17843) * Update DBG_MAX_EXECUTABLE_ALLOC_SIZE and EXPECTED_CHUNKSIZE to account recent SharedPatchBypassBuffer changes * Comment-only update Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Improve EXPECTED_CHUNKSIZE comment --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates debugger heap constants to accommodate recent changes to the SharedPatchBypassBuffer. The changes adjust memory allocation limits and chunk sizes to ensure proper functionality of the debugger's executable memory management.
- Updates maximum executable allocation size from 112 to 120 bytes to match the size of SharedPatchBypassBuffer
- Doubles the expected chunk size from 128 to 256 bytes to accommodate the larger allocation requirements
- Adds detailed comments explaining the rationale and requirements for these constants
hoyosjs
approved these changes
Jul 22, 2025
af84ec9
into
dotnet:release/10.0-preview7
15 of 76 checks passed
This was referenced Jul 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #117843 from main to .NET 10 Preview 7 branch