[RuntimeAsync] Make JitOptimizeAwait not a release switch.#117574
Merged
VSadov merged 1 commit intodotnet:mainfrom Jul 15, 2025
Merged
[RuntimeAsync] Make JitOptimizeAwait not a release switch.#117574VSadov merged 1 commit intodotnet:mainfrom
VSadov merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @mangod9 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes JitOptimizeAwait a regular JIT configuration option instead of a release-only switch and updates the importer to apply await optimization by default in release builds.
- Changed the configuration macro for
JitOptimizeAwaitinjitconfigvalues.h - Updated
importer.cppto remove the release-only guard aroundJitOptimizeAwait
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/jitconfigvalues.h | Changed JitOptimizeAwait from a RELEASE_CONFIG_INTEGER to an OPT_CONFIG_INTEGER |
| src/coreclr/jit/importer.cpp | Wrapped the JitOptimizeAwait() check under #ifdef DEBUG, enabling the optimization in release |
Comments suppressed due to low confidence (2)
src/coreclr/jit/jitconfigvalues.h:587
- [nitpick] Since
JitOptimizeAwaitis now a regular configurable option, consider updating any related documentation or comments to reflect its broader availability beyond release switches.
OPT_CONFIG_INTEGER(JitOptimizeAwait, "JitOptimizeAwait", 1) // Perform optimization of Await intrinsics
src/coreclr/jit/importer.cpp:9105
- Removing the runtime check for
JitOptimizeAwait()in release causesimpMatchTaskAwaitPatternto run on every async method, which may impact JIT throughput; please benchmark or consider retaining a lightweight guard.
if (compIsAsync())
Open
3 tasks
jakobbotsch
approved these changes
Jul 14, 2025
Member
Author
|
/ba-g Android timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trivial change.
Closes: #115264
The switch may still be useful for testing/investigating issues, but not as interesting in benchmarking. Thus does not need to be release switch.