Fix HFA treatment of floating-point-based enums. #115591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n IL) as an HFA in crossgen2 like we do for CoreCLR.
Member
Author
|
/azp run runtime-coreclr crossgen2 outerloop |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the handling of floating-point-based enums for HFA computation, aligning the behavior with CoreCLR.
- Adjusts the enum type handling to use the underlying type instead of the enum type itself.
- Adds a clarifying comment explaining the rationale behind the change.
Comments suppressed due to low confidence (2)
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs:1084
- Add unit tests to validate that floating-point-based enums are correctly treated as HFAs.
MetadataType metadataType = (MetadataType)type.UnderlyingType;
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs:1084
- Consider verifying or asserting that 'type' is indeed an enum before accessing its 'UnderlyingType' to ensure that the cast is always safe.
MetadataType metadataType = (MetadataType)type.UnderlyingType;
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
May 15, 2025
Member
Author
|
Crossgen-comparison failure is an infra issue in main. Merging this in. |
Member
Author
|
/ba-g iOS failure is unrelated |
This was referenced May 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat enums of floating point types (something that's only possible in IL) as an HFA in crossgen2 like we do for CoreCLR.
Fixes failure in https://dev.azure.com/dnceng-public/public/_build/results?buildId=1041124&view=results.
Fixes #104927