Cleanup the init-vs-env.cmd script #115538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove unnecessary arguments to the MSBuild generators
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the build scripts by unifying the Visual Studio version variable usage and removing unnecessary generator arguments. Key changes include:
- Replacing the custom __VSVersion variable with the standardized VisualStudioVersion for MSBuild generator calls.
- Removing superfluous generator argument settings in some scripts.
- Updating version comparisons in gen-buildsys.cmd to match the new convention.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tests/build.cmd | Updated call to gen-buildsys.cmd to pass VisualStudioVersion. |
| src/native/libs/build-native.cmd | Replaced __VSVersion with VisualStudioVersion in build call. |
| src/native/corehost/build.cmd | Updated echo and call commands to use VisualStudioVersion. |
| src/coreclr/build-runtime.cmd | Consistently substituted __VSVersion with VisualStudioVersion. |
| eng/native/init-vs-env.cmd | Removed redundant Visual Studio version conditionals. |
| eng/native/gen-buildsys.cmd | Adjusted version check to compare against "17.0". |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
AaronRobinsonMSFT
approved these changes
May 13, 2025
AndyAyersMS
approved these changes
May 14, 2025
hoyosjs
approved these changes
May 14, 2025
This was referenced May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the already-present VisualStudioVersion environment variable and remove unnecessary arguments to the MSBuild generators.