Fix instance size emission in ILCompiler to handle indeterminate sizes #115293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/UserDefinedTypeDescriptor.cs
Outdated
Show resolved
Hide resolved
…TypeDescriptor.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect class size emission for reference types in NativeAOT PDBs, which caused IDA and other debuggers to ignore most fields.
See discussion and issue here:
#115283 (comment)
Before this fix, the emitted size would always be the pointer size (e.g., 8), even if the actual instance size was known and available. This caused debuggers to parse only the base class portion of the type.
After this fix, we use
defType.InstanceByteCountinstead ofGetElementSize()for class types when the size is determinate.