Skip to content

Add runtimeconfig switch for Thread_UseAllCpuGroups/Thread_AssignCpuGroups#114799

Merged
eduardo-vp merged 1 commit into
dotnet:mainfrom
eduardo-vp:add-runtimeconfig-property-for-thread-useallcpugroups
Apr 22, 2025
Merged

Add runtimeconfig switch for Thread_UseAllCpuGroups/Thread_AssignCpuGroups#114799
eduardo-vp merged 1 commit into
dotnet:mainfrom
eduardo-vp:add-runtimeconfig-property-for-thread-useallcpugroups

Conversation

@eduardo-vp

Copy link
Copy Markdown
Member

Fixes #81713.

Copilot AI review requested due to automatic review settings April 17, 2025 19:20
@ghost ghost added the area-VM-coreclr label Apr 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a runtime configuration switch to control thread CPU group usage based on issue #81713.

  • Updated configuration retrieval for thread CPU group settings.
  • Replaced CLRConfig calls with Configuration::GetKnobBooleanValue for better consistency.

Comment thread src/coreclr/utilcode/util.cpp Outdated

@kouvel kouvel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eduardo-vp eduardo-vp merged commit 283face into dotnet:main Apr 22, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOTNET_Thread_UseAllCpuGroups does not have a runtimeconfig equivalent property

3 participants