Ignore CLR_DOTNET_RID when using stub cdac#114541
Merged
jkoritzinsky merged 3 commits intodotnet:mainfrom Apr 11, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @hoyosjs |
am11
commented
Apr 11, 2025
src/coreclr/jit/compiler.h
Outdated
Comment on lines
19
to
21
| // dummy change to trigger formatting job | ||
|
|
||
| /*****************************************************************************/ |
Member
Author
There was a problem hiding this comment.
Formatting jobs are green https://github.com/dotnet/runtime/actions/runs/14404851447?pr=114541, undoing the dummy change.
Suggested change
| // dummy change to trigger formatting job | |
| /*****************************************************************************/ | |
| /*****************************************************************************/ |
max-charlamb
approved these changes
Apr 11, 2025
Member
max-charlamb
left a comment
There was a problem hiding this comment.
LGTM. Shouldn't impact cDAC builds.
Member
Author
|
@jkoritzinsky, side note for ongoing RID convergence; we can define |
jkoritzinsky
approved these changes
Apr 11, 2025
Member
|
There's a slight difference. The one in corehost can be a non-portable RID. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using stub cdac (i.e. when building just runtime without msbuild:
src/coreclr/build-runtime.sh), it shouldn't validateCLR_DOTNET_RID.Fix #114538.