Skip to content

Fix IsVNConstantBound assert #114486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EgorBo merged 4 commits into from
Apr 14, 2025
Merged

Fix IsVNConstantBound assert #114486

EgorBo merged 4 commits into from
Apr 14, 2025

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 10, 2025

Fixes #114212

Copilot AI review requested due to automatic review settings April 10, 2025 13:10
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2025
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 10, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo
Copy link
Member Author

EgorBo commented Apr 10, 2025

/azp run runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo
Copy link
Member Author

EgorBo commented Apr 11, 2025

/azp run runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 11, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo
Copy link
Member Author

EgorBo commented Apr 11, 2025 •
edited
Loading

PTAL @AndyAyersMS @jakobbotsch @dotnet/jit-contrib fixes a jitstress issue.

Basically, for switch's default case we used to create a slightly invalid assertion (O1K_CONSTANT_LOOP_BND or O1K_CONSTANT_LOOP_BND_UN).

Now the algorithm is:

We try to create O1K_CONSTANT_LOOP_BND (which is X signed_relop CNS) if opVN (switch'a op) and value (largest const value we test for, >0) are known to be never negative, and create O1K_CONSTANT_LOOP_BND_UN if know nothing about opVN's range.

A few small diffs . Looks like Format JIT jobs are broken

@EgorBo EgorBo requested a review from AndyAyersMS April 11, 2025 11:51
@build-analysis build-analysis bot mentioned this pull request Apr 11, 2025
Open
3 tasks
@EgorBo EgorBo merged commit e9d9995 into dotnet:main Apr 14, 2025
111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed IsVNConstantBound(vn) || IsVNConstantBoundUnsigned(vn) during 'Assertion prop'

2 participants

@EgorBo @AndyAyersMS