Don't run RangeCheck if no GT_BOUNDS_CHECK were seen#112512
Merged
EgorBo merged 5 commits intodotnet:mainfrom Feb 14, 2025
Merged
Don't run RangeCheck if no GT_BOUNDS_CHECK were seen#112512EgorBo merged 5 commits intodotnet:mainfrom
EgorBo merged 5 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- src/coreclr/jit/compiler.h: Language not supported
- src/coreclr/jit/morph.cpp: Language not supported
- src/coreclr/jit/rangecheck.cpp: Language not supported
- src/coreclr/jit/valuenum.cpp: Language not supported
- src/coreclr/jit/valuenumtype.h: Language not supported
Member
Author
|
PTAL @dotnet/jit-contrib simple change, Diffs. |
amanasifkhalid
approved these changes
Feb 13, 2025
src/coreclr/jit/compiler.h
Outdated
| #define OMF_HAS_RECURSIVE_TAILCALL 0x00040000 // Method contains recursive tail call | ||
| #define OMF_HAS_EXPANDABLE_CAST 0x00080000 // Method contains casts eligible for late expansion | ||
| #define OMF_HAS_STACK_ARRAY 0x00100000 // Method contains stack allocated arrays | ||
| #define OMF_HAS_BOUND_CHECKS 0x00200000 // Method contains bounds checks |
Contributor
There was a problem hiding this comment.
nit: Should we make it consistent with GT_BOUNDS_CHECK, and call it OMF_HAS_BOUNDS_CHECKS?
tannergooding
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, make
m_conservativebe the first field inValueNumPairbecause we access it more frequently thanm_liberal.Improves JIT TP. Diffs.