Run TypeIntrinsics tests with native AOT#112477
Merged
MichalStrehovsky merged 3 commits intodotnet:mainfrom Feb 14, 2025
Merged
Run TypeIntrinsics tests with native AOT#112477MichalStrehovsky merged 3 commits intodotnet:mainfrom
MichalStrehovsky merged 3 commits intodotnet:mainfrom
Conversation
I don't think the `CreateDynamic` flavors test anything interesting from codegen perspective. The `IsValueType` and `IsValueTypeObj` methods are going to be called using reflection, but nothing interesting will happen in the method body (it's a very regular method body). All the `dynamic` keyword is doing there is that a ton of reflection is going to happen before we execute the regular method body.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
EgorBo
approved these changes
Feb 12, 2025
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
1 similar comment
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think the
CreateDynamicflavors test anything interesting from codegen perspective. TheIsValueTypeandIsValueTypeObjmethods are going to be called using reflection, but nothing interesting will happen in the method body (it's a very regular method body). All thedynamickeyword is doing there is that a ton of reflection is going to happen before we execute the regular method body.Cc @dotnet/ilc-contrib