JIT: Mark profile inconsistent during flow opts if OSR entry is involved #111362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. No diffs (only affects debug assert behavior). Thanks! |
Contributor
Author
AndyAyersMS
approved these changes
Jan 13, 2025
Contributor
Author
|
/ba-g macOS arm64 tests are hanging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSR entry weights are frequently imbalanced, so we skip profile consistency checks for them. However,
fgUpdateFlowGraphcan propagate these weights to normal blocks, which are checked for profile consistency. If we think this happened, liberally mark the profile as inconsistent. Fixes #111343.