Remove HMFs from JIT helpers #111034
Merged
Remove HMFs from JIT helpers #111034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These JIT helpers are only used in EnC scenarios so their performance is secondary.
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (13)
- src/coreclr/classlibnative/bcltype/arraynative.cpp: Language not supported
- src/coreclr/classlibnative/bcltype/arraynative.h: Language not supported
- src/coreclr/inc/jithelpers.h: Language not supported
- src/coreclr/jit/utils.cpp: Language not supported
- src/coreclr/vm/corelib.h: Language not supported
- src/coreclr/vm/ecalllist.h: Language not supported
- src/coreclr/vm/field.cpp: Language not supported
- src/coreclr/vm/field.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/metasig.h: Language not supported
- src/coreclr/vm/qcallentrypoints.cpp: Language not supported
- src/coreclr/vm/reflectioninvocation.cpp: Language not supported
- src/coreclr/vm/runtimehandles.h: Language not supported
Comments suppressed due to low confidence (3)
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs:1670
- [nitpick] The error message is too generic. Consider providing a more descriptive error message indicating the failure to get the field address.
throw new NullReferenceException();
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs:1679
- [nitpick] The error message is too generic. Consider providing a more descriptive error message indicating the failure to get the static field address.
throw new NullReferenceException();
src/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs:42
- Ensure that the new method CreateInstanceMDArray is covered by tests.
internal static unsafe object CreateInstanceMDArray(nint typeHandle, uint dwNumArgs, void* pArgList)
Member
Author
|
@EgorBot -amd -arm using System;
using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
public class Bench
{
[MethodImpl(MethodImplOptions.NoInlining)]
static object Alloc<T>(int a, int b, int c)
{
return new T[a, b, c];
}
[Benchmark]
public object MDInt() => Alloc<int>(1,2,3);
[Benchmark]
public object MDObject() => Alloc<object>(1,2,3);
[Benchmark]
public object MDGuid() => Alloc<Guid>(1,2,3);
} |
jkotas
reviewed
Jan 2, 2025
25 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
JIT_GetFieldAddrandJIT_GetStaticFieldAddrto C#.performance is secondary.
Convert
JIT_NewMDArrto C#.Contributes to #95695