Ensure proper cleanup of key files when not persisting them #109731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code inspection suggested that keys imported into the CNG MachineKey store from PFXImportCertStore were not getting properly cleaned up. This change adds tests that prove that supposition, and then fixes the bug so they pass.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
vcsjones
reviewed
Nov 12, 2024
...libraries/System.Security.Cryptography/tests/X509Certificates/X509FilesystemTests.Windows.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography/tests/X509Certificates/X509FilesystemTests.Windows.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography/tests/X509Certificates/X509FilesystemTests.Windows.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography/tests/X509Certificates/X509FilesystemTests.Windows.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography/tests/X509Certificates/X509FilesystemTests.Windows.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography/tests/X509Certificates/X509FilesystemTests.Windows.cs
Show resolved
Hide resolved
* Bump keysize to 2048 * This caused the tests to be too slow, so reuse 6 random keys for all of them * Remove the random ordering in machine-or-user for defaultkeyset (try both ways) * Remove incorrect copy/paste comment * Remove bad nullable annotation
This was referenced Nov 13, 2024
Open
vcsjones
approved these changes
Nov 14, 2024
Member
Author
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11844527380 |
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/11844532108 |
This was referenced Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code inspection suggested that keys imported into the CNG MachineKey store from PFXImportCertStore were not getting properly cleaned up. This change adds tests that prove that supposition, and then fixes the bug so they pass.