Skip to content

Crossgen2 outer loop fixes #108819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 7 commits into from
Oct 15, 2024
Merged

Crossgen2 outer loop fixes #108819

jkotas merged 7 commits into from
Oct 15, 2024

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Oct 13, 2024 •
edited
Loading

Fixes #106948

@build-analysis build-analysis bot mentioned this pull request Oct 13, 2024
Closed
3 tasks
@jkotas
Copy link
Member Author

jkotas commented Oct 13, 2024

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 13, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Oct 13, 2024

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 13, 2024

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 13, 2024
Open
Closed
@jkotas
Copy link
Member Author

jkotas commented Oct 14, 2024

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Oct 14, 2024
Open
@jkotas
Copy link
Member Author

jkotas commented Oct 14, 2024

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Oct 14, 2024

Re: #107772 (comment)

@ivdiazsa @kg This should fix the recent breaks introduced in crossgen2 outer loop. (It does not make it green, but only about as broken as it was before.)

@jkotas jkotas requested review from ivdiazsa and kg October 14, 2024 10:50
@jkotas jkotas marked this pull request as ready for review October 14, 2024 10:50
kg
kg approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert, but this all looks good to me. Thanks for digging in and fixing this.

@elinor-fung elinor-fung mentioned this pull request Oct 14, 2024
Closed
ivdiazsa
ivdiazsa approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ivdiazsa ivdiazsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for your help with this Jan!

@jkotas jkotas merged commit 6a9e153 into dotnet:main Oct 15, 2024
@jkotas jkotas deleted the crossgen2-fixes branch October 15, 2024 02:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kg kg kg approved these changes

+1 more reviewer

@ivdiazsa ivdiazsa ivdiazsa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkotas jkotas

Labels

area-crossgen2-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure: readytorun/coreroot_determinism/coreroot_determinism/coreroot_determinism.cmd

3 participants

@jkotas @kg @ivdiazsa