[release/9.0] [mono] Revert "don't define HAS_CUSTOM_BLOCKS on mono (#106764)" #107675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7266021.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-memory |
vitek-karas
approved these changes
Sep 11, 2024
jeffschwMSFT
approved these changes
Sep 11, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review and this can be merged when ready
EgorBo
approved these changes
Sep 11, 2024
Member
|
cc: @carlossanlop it's ready to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107558 to release/9.0
/cc @matouskozak
Customer Impact
The #106801 caused significant improvements for MonoJIT but introduced unexpected regressions for MonoAOT/MonoInterpreter described at #107308 (comment). We decided that the safest approach for .NET 9 is to keep MonoJIT regressed and do not introduce new regressions to MonoAOT and MonoInterpreter.
Regression
Found using Performance measurements on dotnet/runtime main.
Testing
Revert of #106801, we expect to get to the state before the original commit.
Risk
Low: this is a revert of previous backport #106801.