Ensure that constant folding of bitwise operations for float/double are bitwise #106711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duplicate definitions
This was referenced Aug 20, 2024
Member
Author
|
CC. @dotnet/jit-contrib, @AndyAyersMS This should be ready for review and resolves #106610. It will need backport for .NET 9 RC2 |
AndyAyersMS
approved these changes
Aug 21, 2024
28f8554 to
eff1995
Compare
Member
Author
|
(Pushed a commit to the wrong branch by accident, reverted back to the approved commit) |
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10513909881 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #106610
As per the discussion on the issue, the behavior of the CPU converting an
sNaNinto aqNaNis within spec and the expected behavior on most platforms, particularly when dealing with scalars. However, this is not the behavior encountered when dealing with SIMD vectors on most platforms.This fix ensures that constant folding will produce the same result as the underlying instruction by performing the bitwise operation directly on the integral bits, rather than first extracting it to the base type (float or double).