[ObjWriter/Mach-O] Mark non-global symbols as .private_extern to match ELF #106446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Member
|
/azp run runtime-nativeaot-outerloop, runtime-extra-platforms |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
Cc @ivanpovazan @dotnet/jit-contrib @dotnet/ilc-contrib for Apple-specific ObjWriter change. Looks reasonable to me but don't know much about Apple stuff. |
jkotas
approved these changes
Aug 19, 2024
Member
jkotas
left a comment
There was a problem hiding this comment.
LGTM
@filipnavara I assume that we do not need to backport this fix to .NET 9. Correct?
Member
Author
Correct. I don't see a need to backport it at this point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #106224
.private_externis the logical equivalent of.hidden+.globalin ELF. We already emit those flags in ELF, so do it in Mach-O too.Documentation for
.private_extern: