Skip to content

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 12, 2024

When loading the cDAC, we were relying on GetClrModuleDirectory in the DAC actually giving us the DAC directory. With #106217, it explicitly stores/uses the CLR module base. When we first try to load the cDAC in the DAC, that has not yet been set. The current intent is to actually load from next to the DAC, so switch the logic to look next to the current module for the cDAC instead of using the CLR module directory.

Also renamed GetCurrentModuleFileName in utilcode to GetCurrentExecutableFileName so that it accurately represents what it does (I tried to use it and was sad).

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@tommcdon tommcdon requested a review from mikem8361 August 12, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants