Consume the existing instruction metadata when validating expected memory size #106090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
commented
Aug 7, 2024
src/tests/JIT/Regression/JitBlue/Runtime_105624/Runtime_105624.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 8, 2024
8b5935a to
d811b17
Compare
Member
Author
|
/azp run runtime-coreclr jitstress-isas-x86 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
CC. @dotnet/jit-contrib, this should be ready for review and resolves #105624 As per the top post, this consumes the existing instruction metadata which gives a correct view of what each instruction expects its memory operands to be and so removes the need to continue adding many one off handlings. |
TIHan
approved these changes
Aug 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #105624
We notably already had all the "correct" information as part of the instruction descriptor tables, so this just consumes that directly rather than special-casing a bunch of one off instructions in the
emitGetBaseMemOpSizemethod.This information is only used in DEBUG as part of validating alignment for method local constants and for displaying the JIT disassembly. There's additional cleanup/simplification possible, but that can wait for .NET 10 since its not causing any test failures or asserts.