Don't warn for reflection access to compiler-generated code #104757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2024
Open
MichalStrehovsky
approved these changes
Jul 12, 2024
Comment on lines
-185
to
+187
| CompilerGeneratedMemberAccessedViaReflection = 2118, | ||
| DynamicallyAccessedMembersOnTypeReferencesCompilerGeneratedMember = 2119, | ||
| DynamicallyAccessedMembersOnTypeReferencesCompilerGeneratedMemberOnBase = 2120, | ||
| _unused_CompilerGeneratedMemberAccessedViaReflection = 2118, | ||
| _unused_DynamicallyAccessedMembersOnTypeReferencesCompilerGeneratedMember = 2119, | ||
| _unused_DynamicallyAccessedMembersOnTypeReferencesCompilerGeneratedMemberOnBase = 2120, |
Member
There was a problem hiding this comment.
Will we also doc that people shouldn't expect this warning anymore? We could even go as far as saying this is safe to suppress since it's likely this generates more false positives than point out real issues.
Member
Author
There was a problem hiding this comment.
Looks like we didn't doc these warnings yet so I think we can just leave them undocumented.
Member
Author
|
/ba-g "The machine restarted and Azure DevOps can't recover from restarts." |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85042