Enhancing the SqlDbType with Json#103985
Merged
roji merged 5 commits intodotnet:mainfrom Jul 11, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @roji, @ajcvickers |
Member
|
You'll need to add this member to the enum in the corresponding ref assembly |
Contributor
Author
|
Thanks @jkoritzinsky I will update the ref assembly. What about any docs related changes? |
This was referenced Jun 25, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Closed
Member
|
For docs, I believe you can put XML comments on the change in the src/ folder and they should propagate to docs when the next version with your change ships. @carlossanlop can confirm. |
Contributor
Author
|
@roji this is ready for review. I have answered the question about the docs in the PR description. |
stephentoub
reviewed
Jul 9, 2024
stephentoub
approved these changes
Jul 9, 2024
Contributor
Author
|
cc @apoorvdeshmukh @deepaksa1 for your awareness |
roji
approved these changes
Jul 11, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103925
The API review is approved.
The docs changes will need to be made in https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System.Data/SqlDbType.xml and can be separated from this PR.