Enable CET shadow stack compatibility in apphost/singlefilehost by default
#103007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke |
mangod9
reviewed
Jun 3, 2024
elinor-fung
commented
Jun 3, 2024
mangod9
approved these changes
Jun 3, 2024
Member
mangod9
left a comment
There was a problem hiding this comment.
Thanks for implementing this. We should keep an eye on CI, we had noticed that the CET specific CI was failing with new EH enabled, so wondering if that would affect a wider spectrum after this merges.
jkoritzinsky
reviewed
Jun 3, 2024
This was referenced Jun 4, 2024
Member
|
@elinor-fung please don't merge this change in yet. I was investigating a CET test leg failure yesterday and found a problem with the shadow stack and the new exception handling that needs to be addressed before this change gets in. |
Member
|
@elinor-fung my CET fix is merged in, so please feel free to merge this in once the CI is green. |
Member
Author
|
Thanks, @janvorli! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable CET shadow stack compatibility in apphost/singlefilehost by default
apphostandsinglefilehostwith/cetcompat(shared libraries are already being built with this flag)HostWriter.CreateAppHostThis change makes it so that a user's app will have CET compatibility enabled by default (for Windows x64). There will be a corresponding change on the SDK side such that it can be disabled with
<CetCompat>false</CetCompat>.cc @dotnet/appmodel @janvorli @mangod9