Add System.Net.ServerSentEvents#102238
Merged
Merged
Conversation
|
Note regarding the |
annelo-msft
reviewed
May 15, 2024
Member
Author
|
@MihaZupan, would you be able to help with a code review here? |
MihaZupan
approved these changes
May 30, 2024
MihaZupan
left a comment
Member
There was a problem hiding this comment.
The buffer offsets are a bit hard to follow so I'd consider using ArrayBuffer.
Otherwise LGTM
MihaZupan
reviewed
May 30, 2024
Member
Author
|
Thanks for the review, @MihaZupan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98105
cc: @annelo-msft, @markwallace-microsoft, @trrwilson, @NTaylorMullen, @ericstj