Skip to content

dns.lookup.duration should report error.type #92837

@lmolkova

Description

@lmolkova

Description

Currently dns.lookup.duration only reports duration of he successful lookups, but failed lookups are quite interesting as well (count, rate, duration, failure reason).

Having error.type attribute on the dns.lookup.duration metric and reporting it when DNS lookup fails would provide all the details.

Adding an attribute later is considered a breaking change on OTel, since it increases the number of time series in the metric and breaks alerts and dashboards (so creating it as a bug).

Reproduction Steps

N/A

s_lookupDuration.Record(duration.TotalSeconds, KeyValuePair.Create("dns.question.name", (object?)hostName));

Expected behavior

The metric should have error.type attribute nad report duration of both, failed and successfully lookups.

Actual behavior

Metric only reports successful lookups

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions