Skip to content

NativeAOT can report wrong sizes of native structs #75666

New issue
New issue
Closed
#102645
Closed
NativeAOT can report wrong sizes of native structs#75666
#102645
Labels
area-NativeAOT-coreclrin-prThere is an active PR which will close this issue when it is merged
Milestone
Future
@MichalStrehovsky

Description

@MichalStrehovsky
MichalStrehovsky
opened on Sep 15, 2022

Like the comment says.

runtime/src/coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/RuntimeInteropData.cs

Lines 39 to 45 in 9028dc2

// IsBlittable() checks whether the type contains GC references. It is approximate check with false positives.
// This fallback path will return incorrect answer for types that do not contain GC references, but that are
// not actually blittable; e.g. for types with bool fields.
if (structureTypeHandle.IsBlittable() && structureTypeHandle.IsValueType())
{
return structureTypeHandle.GetValueTypeSize();
}

I'm putting this into Future milestone. We should be able to delete this logic because in theory there should be AOT analysis warnings whenever this API can be problematic and then we're allowed to potentially throw. In practice, deleting this fails many tests and I don't want to deal with it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-NativeAOT-coreclrin-prThere is an active PR which will close this issue when it is merged

    Type

    No type

    Projects

    AppModel

    Status

    No status

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions