Skip to content

float parsing benchmarks have regressed on 32 bit platforms #66838

@adamsitnik

Description

@adamsitnik

System.Text.Json.Tests.Perf_Get.GetSingle has regressed20-35% on 32 bit platforms.

Reporting system:

image

Looking at the commit diff it's most likely caused by #62301 (cc @tannergooding )

Repro:

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 net7.0 --filter System.Text.Json.Tests.Perf_Get.GetSingle --architecture x86
Details
Result Base Diff Ratio Operating System Bit
Same 4212.28 4309.12 0.98 Windows 11 X64
Same 3148.27 3090.19 1.02 Windows 11 X64
Same 6700.49 6771.64 0.99 Windows 11 X64
Same 4020.62 3911.91 1.03 Windows 10 X64
Same 4762.67 4713.94 1.01 Windows 11 X64
Same 6261.90 6353.20 0.99 Windows 11 X64
Same 3296.56 3302.37 1.00 ubuntu 18.04 X64
Same 3239.55 3279.82 0.99 ubuntu 20.04 X64
Same 4849.07 4823.87 1.01 ubuntu 18.04 X64
Faster 8014.18 7156.92 1.12 ubuntu 18.04 X64
Same 5664.32 5763.96 0.98 pop 20.04 X64
Same 4093.16 4155.46 0.99 alpine 3.13 X64
Same 4142.95 4086.97 1.01 debian 11 X64
Same 3019.47 2769.70 1.09 macOS Monterey 12.2.1 Arm64
Same 5855.04 6198.09 0.94 Windows 10 Arm64
Same 5835.18 6237.83 0.94 Windows 11 Arm64
Slower 6937.67 9177.62 0.76 Windows 10 X86
Slower 6132.79 7625.77 0.80 Windows 10 X86
Slower 5636.96 7136.83 0.79 Windows 10 X86
Slower 7610.08 11632.67 0.65 Windows 10 Arm
Same 6309.44 6450.41 0.98 macOS Big Sur 11.6.3 X64
Same 5345.03 5463.62 0.98 macOS Monterey 12.2.1 X64
Same 5618.79 5573.90 1.01 macOS Monterey 12.2.1 X64

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions