-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
area-System.Net.Httpdisabled-testThe test is disabled in source code against the issueThe test is disabled in source code against the issuetest-enhancementImprovements of test source codeImprovements of test source code
Milestone
Description
See here:
| public async Task WaitForCancellationAsync(bool ignoreIncomingData = true) |
All we are doing here is reading to the end of the read stream.
What we should be doing is validating that the client cancels the request, by aborting read and write with H3_REQUEST_CANCELLED. For reference, see the HTTP2 loopback implementation, which is waiting to receive a RST_STREAM.
Perhaps ironically, we need to implement #58229 in order to do be able to do this.
This means that any test that uses WaitForCancellationAsync is not actually validating cancellation properly. For better or worse, most of our cancellation tests don't actually use WaitForCancellationAsync anyway -- though they probably should. I will file a separate issue on that.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-System.Net.Httpdisabled-testThe test is disabled in source code against the issueThe test is disabled in source code against the issuetest-enhancementImprovements of test source codeImprovements of test source code