Skip to content

Remove ! from Microsoft.Extensions.FileSystemGlobbing #58211

@maxkoshevoi

Description

@maxkoshevoi

Description

This is a blanket issue for all ! operations that were added in #57398
They should be removed or reviewed.

Left to be fixed/reviewed:

  • FileSystemInfoBase.ParentDirectory should be able to return null, but none of the implementation do that (! were added to allow that though).
  • Implementations of DirectoryInfoBase differ in nullability for GetDirectory and GetFile
Class Can GetDirectory return null? Can GetFile return null?
DirectoryInfoBase No (according to <returns> doc) No (according to <returns> doc)
DirectoryInfoWrapper Yes No
InMemoryDirectoryInfo No Yes

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions