-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Remove PSEUDORANDOM_NOP_INSERTION and associated code #54242
Copy link
Copy link
Closed
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIhelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged
Milestone
Metadata
Metadata
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIhelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged
Type
Fields
Give feedbackNo fields configured for issues without a type.
While browsing the Jit's source, I noticed this comment:
And the corresponding
#define PSEUDORANDOM_NOP_INSERTION, which is now disabled:So the question is as in the header: do we foresee this being a useful mitigation to have in the future, and if not, should the code supporting it be removed?
cc @jkotas, @BruceForstall
category:implementation
theme:codegen
skill-level:beginner
cost:small
impact:small