-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
area-Infrastructure-installerhelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors
Milestone
Description
Installer's GetLatestCommit target is used to build the corehost and to publish assets. That custom target should be replaceable by what Arcade already offers (version.targets):
runtime/src/installer/Directory.Build.targets
Lines 140 to 151 in 75c0b99
| <Target Name="GetLatestCommitHash" | |
| Condition="'$(LatestCommit)' == ''"> | |
| <!-- Get the latest commit hash --> | |
| <Exec Command="git rev-parse HEAD 2>&1" StandardOutputImportance="Low" IgnoreExitCode="true" IgnoreStandardErrorWarningFormat="true" ConsoleToMSBuild="true"> | |
| <Output TaskParameter="ConsoleOutput" PropertyName="LatestCommit" /> | |
| <Output TaskParameter="ExitCode" PropertyName="LatestCommitExitCode" /> | |
| </Exec> | |
| <!-- We shouldn't fail the build if we can't retreive the commit hash, so in this case just set it to N/A --> | |
| <PropertyGroup Condition="'$(LatestCommitExitCode)'!='0'"> | |
| <LatestCommit>N/A</LatestCommit> | |
| </PropertyGroup> | |
| </Target> |
cc @dotnet/runtime-infrastructure
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-Infrastructure-installerhelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors