-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Description
While working on collapsing the mono official builds into single legs, I noticed that we don't produce a runtime pack for Windows:
runtime/eng/pipelines/runtime-official.yml
Lines 227 to 249 in 704be18
| - template: /eng/pipelines/installer/installer-matrix.yml | |
| parameters: | |
| jobParameters: | |
| liveRuntimeBuildConfig: release | |
| liveLibrariesBuildConfig: Release | |
| isOfficialBuild: ${{ variables.isOfficialBuild }} | |
| useOfficialAllConfigurations: false | |
| buildFullPlatformManifest: false | |
| runtimeFlavor: mono | |
| platforms: | |
| - OSX_x64 | |
| - Linux_x64 | |
| - tvOS_x64 | |
| - tvOS_arm64 | |
| - iOS_arm | |
| - iOS_arm64 | |
| - iOS_x64 | |
| - iOS_x86 | |
| - Android_arm | |
| - Android_arm64 | |
| - Android_x64 | |
| - Android_x86 | |
| - Browser_wasm |
I added that to my test change and the windows build failed with:
F:\workspace\_work\1\s\.packages\microsoft.dotnet.build.tasks.sharedframework.sdk\5.0.0-beta.20280.1\targets\framework.dependency.targets(201,5): Missing FileVersion in 1 shared framework files:
F:\workspace\_work\1\s\artifacts\bin\mono\Windows_NT.x64.Release\coreclr.dll [F:\workspace\_work\1\s\src\installer\pkg\projects\netcoreapp\src\netcoreapp.depproj]
As a workaround I will be setting PermitDllAndExeFilesLackingFileVersion=true for mono on windows in installer/netcoreapp.depproj to start producing the runtime pack for Windows. However, we should fix this.
Reactions are currently unavailable