Suggested severity: info

// Before
        public int TryGet(Dictionary<string, int> data, string key)
        {
            if (data.ContainsKey(key))
            {
                return data[key];
            }
            return 0;
        }
// After
        public int TryGet(Dictionary<string, int> data, string key)
        {
            if (data.TryGetValue(key, out int value))
            {
                return value;
            }
            return 0;
        }

It may be possible to preserve unrelated code inside the if statement as long as key is used without modifying the dictionary:

// Before
        public int TryGet(Dictionary<string, int> data, string key)
        {
            if (data.ContainsKey(key))
            {
                Foo(data[key]); // Unrelated code
                return data[key];
            }
            return 0;
        }
// After
        public int TryGet(Dictionary<string, int> data, string key)
        {
            if (data.TryGetValue(key, out int value))
            {
                Foo(value); // Unrelated code
                return value;
            }
            return 0;
        }

Avoid triggering if the data is modified before returning:

        public int DontTrigger(Dictionary<string, int> data, string key)
        {
            if (data.ContainsKey(key))
            {
                data[key] = DoSoemthing(data[key]); // Unrelated code
                return data[key];
            }
            return 0;
        }

Prefer Dictionary<K, V>.TryGetValue() over guarded indexer access #33798

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions