Skip to content

When initializing WriteStackFrame with re-entry during serialization, consider doing a type comparison #32358

New issue
New issue
Closed
#37170
Closed
When initializing WriteStackFrame with re-entry during serialization, consider doing a type comparison#32358
#37170
Assignees
steveharter
Labels
area-System.Text.Json
Milestone
5.0.0
@ahsonkhan

Description

@ahsonkhan
ahsonkhan
opened on Feb 15, 2020

The intent of this TODO isn't super clear. @steveharter can you help fill in the details or what action is required?

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStackFrame.cs

Lines 97 to 104 in d4b06b1

public JsonConverter InitializeReEntry(Type type, JsonSerializerOptions options, string? propertyName = null)
{
JsonClassInfo newClassInfo = options.GetOrAddClass(type);
// todo: check if type==newtype and skip below?
// Set for exception handling calculation of JsonPath.
JsonPropertyNameAsString = propertyName;

cc @steveharter

Metadata

Metadata

Assignees

Labels

area-System.Text.Json

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions