Skip to content

Create new AssertContentsAgainstJsonNet to avoid calling NormalizeToJsonNetFormat when not necessary. #32351

New issue
New issue
Closed
#34931
Closed
Create new AssertContentsAgainstJsonNet to avoid calling NormalizeToJsonNetFormat when not necessary.#32351
#34931
Labels
area-System.Text.Jsonhelp wanted[up-for-grabs] Good issue for external contributorstest-enhancementImprovements of test source code
Milestone
5.0.0
@ahsonkhan

Description

@ahsonkhan
ahsonkhan
opened on Feb 15, 2020

There are subtle differences between Newtonsoft.Json and S.T.Json on how characters are escaped (upper case hex digits vs lower case), etc. This requires helpers for testing. Capturing the TODO into an issue: dotnet/corefx#39900 (comment).

runtime/src/libraries/System.Text.Json/tests/JsonTestHelper.cs

Lines 721 to 723 in d4b06b1

// Temporary hack until we can use the same escape algorithm on both sides and make sure we want uppercase hex.
// Todo: create new AssertContentsAgainJsonNet to avoid calling NormalizeToJsonNetFormat when not necessary.
Assert.Equal(expectedValue.NormalizeToJsonNetFormat(), value.NormalizeToJsonNetFormat());

runtime/src/libraries/System.Text.Json/tests/JsonTestHelper.cs

Lines 743 to 745 in d4b06b1

// Temporary hack until we can use the same escape algorithm on both sides and make sure we want uppercase hex.
// Todo: create new AssertContentsNotEqualAgainJsonNet to avoid calling NormalizeToJsonNetFormat when not necessary.
Assert.NotEqual(expectedValue.NormalizeToJsonNetFormat(), value.NormalizeToJsonNetFormat());

cc @steveharter

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.Text.Jsonhelp wanted[up-for-grabs] Good issue for external contributorstest-enhancementImprovements of test source code

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions