-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed as not planned
Closed as not planned
Copy link
Labels
area-Infrastructure-librariesenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors
Milestone
Description
Running /t:GenerateReferenceSource leads to a ton of differences between the generated files and what we currently have for the refs. Some of the differences are by design, e.g. ifdefs, but many are not:
- Out-of-order members
- Missing _dummy or _dummyPrimitive fields (which seems like it could be a bug)
- Missing protected ctors on abstract classes
- Whitespace differences, e.g. blank lines, spaces between generic type parameters, etc.
- Missing namespace qualifiers
- Numeric vs named Flags enum attribute arguments
- etc.
It would be good to clean all of this up, in order to a) do an audit to make sure nothing important is wrong, and b) make it easier in the future to use GenerateReferenceSource for minor additions without then needing to deal with a ton of noise.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-Infrastructure-librariesenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors